-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Constants cleanup #4264
Open
arielj
wants to merge
17
commits into
main
Choose a base branch
from
some-constants-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tart extracting env constants and paths
arielj
requested review from
Etaash-mathamsetty,
a team,
flavioislima,
CommandMC,
Nocccer and
imLinguin
and removed request for
a team
January 11, 2025 03:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
backend/constants.ts
file was getting out of hands since a long time ago, it was a bucket to put things from all types, paths, urls, helper booleans, it also did initialization of the logger, had some helper functions related to steam, it was a long and complicated file.This also created problems when wanting to import one thing from that file could lead into issues with the file doing unexpected things.
This PR splits the file into different concerns and also moves some constants to other places where they make more sense:
storeManagers/<store>/constants.ts
, so all gog paths are next to the gog file, nile paths next to the nile paths, etcisXyz
booleans), key_value_stores for the electron stores (I think these can be moved somewhere else though), and others (to collect some things I didn't know where to put)installed
(renamed tolegendaryInstalled
), orflatPakHome
renamed asflatpakHome
isAppImage
that could be useful in the futureinitLogger
module, makes more sense thereI can split this into smaller PRs if it's easier to check and test, but I think the changes are pretty repetitive through all the files, just changing imports in most of them.
Use the following Checklist if you have changed something on the Backend or Frontend: