upgrades rocket to 0.5 #132
Conversation
There was a problem hiding this comment.
Nice, looks like the next rocket version, when it is finally released…, will provide some interesting asynchronous wins. I wonder if it could be moved to oxide-auth-async even. Don't worry about that latter part in this PR though, that would be much harder to review.
| let default_query_uri = uri!("?b"); | ||
| let default_query = default_query_uri.query().unwrap(); | ||
| let query = request.uri().query().unwrap_or(default_query); |
There was a problem hiding this comment.
This will need some justification/explanation as in additional comments. Why this specific query string instead of the empty one previously? Is there some type change that requires this—in a first look it seems that maybe a simple clone &query.to_string() would have sufficed? Justifiy the unwraps as well, please.
There was a problem hiding this comment.
Will try more tomorrow, there have been changes to uri/query that broke the previous code.
| // Nothing to do if we already have a body, or already generated an error. This includes | ||
| // the case where the content type does not indicate a form, as the error is silent until a | ||
| // body is explicitely requested. | ||
| if let Ok(None) = self.body { | ||
| match serde_urlencoded::from_reader(data.open()) { | ||
| let data = data.open(2.mebibytes()).into_string().await; |
There was a problem hiding this comment.
Arbitrary limit should be a constant somewhere, or, even better, be configurable on the object for the caller. Probably both where a default is set with a constant and it can be overwritten.
|
Since 4 months ago, |
|
Work took over and I hadn't had a chance to look into this since then. Sorry about that. |
|
Please don't worry about it. Same for me, and rocket dragged that out quite a bit as well. It's FOSS because we appreciate what you do, however far it goes 😄 |
This changes/fixes/improves …
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.
Let me know if I can improve anything.