-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump NUnit from 3.14.0 to 4.0.1 #161
Conversation
Bumps [NUnit](https://github.com/nunit/nunit) from 3.14.0 to 4.0.1. - [Release notes](https://github.com/nunit/nunit/releases) - [Changelog](https://github.com/nunit/nunit/blob/master/CHANGES.md) - [Commits](nunit/nunit@v3.14.0...v4.0.1) --- updated-dependencies: - dependency-name: NUnit dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
namespace BadMedicine.Datasets; | ||
|
||
/// <include file='../../Datasets.doc.xml' path='Datasets/Prescribing'/> | ||
public sealed class PrescribingRecord |
Check notice
Code scanning / CodeQL
Missing a summary in documentation comment Note
if (r.Next(10) == 0) | ||
DateOfDeath = DataGenerator.GetRandomDateAfter(DateOfBirth, r); | ||
else | ||
DateOfDeath = null; |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
public BiochemistryRecord(Random r) | ||
{ | ||
//get a random row from the lookup table - based on its representation within our biochemistry dataset | ||
var row = BucketList.GetRandom(r); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
row
public static DataTable EmbeddedCsvToDataTable(Type requestingType, string resourceFileName, DataTable dt = null) | ||
{ | ||
var lookup = GetResourceStream(requestingType, resourceFileName) ?? throw new Exception($"Could not find embedded resource file {resourceFileName}"); | ||
var toReturn = dt ?? new DataTable(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
toReturn
public static DataTable EmbeddedCsvToDataTable(Type requestingType, string resourceFileName, DataTable dt = null) | ||
{ | ||
var lookup = GetResourceStream(requestingType, resourceFileName) ?? throw new Exception($"Could not find embedded resource file {resourceFileName}"); | ||
var toReturn = dt ?? new DataTable(); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
} | ||
|
||
var operationsTable = new DataTable(); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
Document new use of Equ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot squash and merge
Bumps NUnit from 3.14.0 to 4.0.1.
Release notes
Sourced from NUnit's releases.
Changelog
Sourced from NUnit's changelog.
... (truncated)
Commits
dd02233
Merge pull request #4575 from nunit/prepare401ea10cbc
Prepare patch release 4.0.1cfcbc97
Merge pull request #4574 from manfred-brands/Issue4564-SupportedOSPlatform112729c
Add support for Windows10Server to OSPlatformTranslator866d5a4
Merge pull request #4569 from manfred-brands/Issue4564-SupportedOSPlatform5e557a6
Expand SupportOSPlatform to mean minimum supported version5f6c8c2
Add locking to dictionary access in ConcurrentTestd91b4cf
Merge pull request #4562 from nunit/prepare40-2fb95a28
Fixed package description31b3786
Merge pull request #4560 from nunit/prepare40Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @jas88.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)