-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove usage of deprecated Dropdown and Selector components #2225
base: master
Are you sure you want to change the base?
Conversation
…meRangeSelct.tsx and ViewSelect.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @barreiro,
It looks really great to me! I tried to play a little bit with the Horreum and all looks good, I did not spot anything wrong but I'd like another pair of eyes to double check this.
82d27a4
to
8245c27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My memory of the UI code is quite outdated. Thank you for bringing the UI closer to the current era :)
I replaced with the
SimpleSelect
(and variants) template in most places. There were other options that could be used, but this one was the easier to work with, looked good and also deals well with long lists of options that overflow.