Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove usage of deprecated Dropdown and Selector components #2225

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

barreiro
Copy link
Collaborator

@barreiro barreiro commented Jan 2, 2025

I replaced with the SimpleSelect (and variants) template in most places. There were other options that could be used, but this one was the easier to work with, looked good and also deals well with long lists of options that overflow.

@barreiro barreiro requested review from willr3 and lampajr January 2, 2025 16:00
@barreiro
Copy link
Collaborator Author

barreiro commented Jan 2, 2025

the only major change in layout is in LabelSelect.tsx where a complex dropdown was used. I moved the filtering so that I could use a template like in other places.

Here is the before
horreum-dev corp redhat com_test_13(Horreum Docs)
and after
localhost_8080_(Horreum Docs)

Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @barreiro,

It looks really great to me! I tried to play a little bit with the Horreum and all looks good, I did not spot anything wrong but I'd like another pair of eyes to double check this.

horreum-web/src/domain/runs/JsonPathSearchToolbar.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@willr3 willr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My memory of the UI code is quite outdated. Thank you for bringing the UI closer to the current era :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants