PCIe topology detection #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranocha
requested changes
Mar 29, 2019
|
You've also reverted the changes to |
|
Is there still something missing or can this be merged now? |
ranocha
reviewed
Mar 30, 2019
| } | ||
| std::string compile_options = std::string(" ") + std::string(options); | ||
|
|
||
| try { |
There was a problem hiding this comment.
Here are some indentation errors.
| nvidia_temp.clear(); | ||
| nvidia_temp_time.clear(); | ||
| void nvidia_log_temp_func() { | ||
| if (nvidia_temp_rate > 0) |
There was a problem hiding this comment.
Didn't we want to use 2 spaces instead of 4?
ranocha
approved these changes
Mar 30, 2019
ranocha
approved these changes
Mar 31, 2019
|
|
||
| try { | ||
| cl_prog.build(compile_options.c_str()); | ||
| cl_prog.build(compile_options.c_str()); | ||
| } | ||
| catch (cl::BuildError error) { |
|
So we just merge this PR and then do a second debug mode PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added automatic PCIe detection and matching between OpenCL and NVML for NVidia devices to solve #38