Repository navigation
Allow dosdp_validation in PAT=false - #39
Merged
Merged
Conversation
In QC we tend to not run dosdp patterns (PAT=false); but validating the dosdp patterns themselves is actually important during QC and takes only a few seconds to do. Here, we make it possible to run dosdp_validation regardless of how PAT is set.
Contributor
Author
|
Fixed this while working on obophenotype/bio-attribute-ontology#458 |
gouttegd
approved these changes
Oct 9, 2026
| patterns dosdp: dosdp_validation $(PATTERNDIR)/pattern.owl $(PATTERNDIR)/definitions.owl | ||
|
|
||
| .PHONY: pattern_schema_checks | ||
| # Validation only reads the pattern files, so it runs regardless of PAT |
Collaborator
There was a problem hiding this comment.
I don’t really like the idea of changing the meaning of PAT from “all pattern-related workflows” to “all pattern-related workflows EXCEPT validation of patterns” – but then again, I also didn’t very much like the idea of redefining dosdp_validation to make it a dummy target under PAT=false, so all things considered…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In QC we tend to not run dosdp patterns (PAT=false); but validating the dosdp patterns themselves is actually important during QC and takes only a few seconds to do. Here, we make it possible to run dosdp_validation regardless of how PAT is set.