Repository navigation
Run the OBO report on $(SRCMERGED) rather than -edit. - #43
Merged
Merged
Conversation
When the user asks for the ROBOT report to be run on the "edit" file, we should really run it on the `$(SRCMERGED)` file. This is because `robot report` does not follow imports, so running the report on the `-edit` file would really only check the contents of that file, ignoring everything that only exists in components -- but components are an integral part of the ontology, it does not make sense to exclude them. Running the report for the `-edit` file really on `$(SRCMERGED)` was the normal ODK behaviour until the template refactoring in #20. That this report is for now run strictly on the `-edit` file is a regression, which we are fixing here. closes #42
matentzn
approved these changes
Oct 13, 2026
matentzn
left a comment
matentzn
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me!
The new rule seems identical to me to the generic one up top but I guess somehow the conditionals make it hard to reuse the rule directly to keep it from drifting
Collaborator
Author
It is. The only difference is the file it is executed on: $(REPORTDIR)/$(SRC)-obo-report.tsv: $(SRCMERGED)
$(ROBOT) report -i $<instead of $(REPORTDIR)/%-obo-report.tsv: %
$(ROBOT) report -i $<Unfortunately, there isn’t really an easy way to factor the two rules. At least not without changing the original rule completely, and I don’t think this is worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user asks for the ROBOT report to be run on the “edit” file, we should really run it on the
$(SRCMERGED)file. This is becauserobot reportdoes not follow imports, so running the report on the-editfile would really only check the contents of that file, ignoring everything that only exists in components – but components are an integral part of the ontology, it does not make sense to exclude them.Running the report for the
-editfile really on$(SRCMERGED)was the normal ODK behaviour until the template refactoring in #20. That this report is for now run strictly on the-editfile is a regression, which we are fixing here.closes #42