[stevenwinship]

What this PR does / why we need it:Modern UI is always getting the old metrics regardless of the DisplayMDCMetrics setting. JSF UI displays based on the setting. The response to /api/datasets/{id}/download/count?includeMDC=true or false should return the requested metrics where not including the parameter 'includeMDC' should base the output on the setting.

Which issue(s) this PR closes: IQSS/dataverse.harvard.edu#491

• Closes # Fix MDC api to allow modern UI to get the metrics based on the setting :DisplayMDCMetrics dataverse.harvard.edu#491

Special notes for your reviewer:The old code was showing MDC date when includeMDC was false. The Json response still contains the 'downloadCount' so there is no break in backward compatibility.

Suggestions on how to test this: Test with multiple variations of settings and api parameter. Downloading will increment the old metrics but not MDC. MDC needs the logs to be loaded. PSQL inserts to 'datasetmetrics' for MDC.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

[coveralls]

coverage: 25.665% (-0.002%) from 25.667% — 491-fix-mdc-api-for-modern-ui into develop

[github-actions]

Test Results

417 tests  ±0   403 ✅ ±0   29m 35s ⏱️ +10s
 59 suites ±0    14 💤 ±0 
 59 files   ±0     0 ❌ ±0 

Results for commit 3684032. ± Comparison against base commit 19fdcb2.

♻️ This comment has been updated with latest results.

[ChengShi-1]

Thanks for fixing the counting issues. After another look, I have two additional comments below.

[ChengShi-1]

Thanks for the fix. Looks good

[sonarqubecloud]

Quality Gate failed

Failed conditions
2.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:491-fix-mdc-api-for-modern-ui

ghcr.io/gdcc/configbaker:491-fix-mdc-api-for-modern-ui

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.