Repository navigation
Fixed XLSX ingest when the first row has no spans attribute - #12860
Open
adityaanikam wants to merge 1 commit into
Open
adityaanikam wants to merge 1 commit into
adityaanikam wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ingest of an XLSX file failed with a
NullPointerExceptionwhen the first row of the worksheet has nospansattribute, which is optional in SpreadsheetML. The reader only usedspansto get the number of columns. When it is missing, the number of columns is now the highest cell position found in the first row.Which issue(s) this PR closes:
Special notes for your reviewer:
I counted the cells of the first row instead of reading the
dimensionelement of the sheet, becausedimensionis optional too. Files that havespansgo through the same code as before.Suggestions on how to test this:
Run
XLSXFileReaderTest. It builds a small XLSX in memory, with and withoutspanson the first row. The test withoutspansfails ondevelop. To try it by hand, upload an XLSX whose first row looks like<row r="1">and let ingest run.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, a snippet is included.
Additional documentation:
None.