Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken dynamic-scheduler #915

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 20, 2024

What do these changes do?

When running a NiceGUI application in multiples copies it is recommended to use sticky sessions since the application does not have any other mechanism to sync session internally.

Without sticky sessions the UI will reload continuously.
This is achieved easily with the use of Traefik.

For details see https://github.com/zauberzeug/nicegui/wiki/FAQs#how-to-avoid-the-reloading-because-handshake-failed-javascript-error-message-which-results-in-a-full-page-reload

Removed prefix stripping since it is not required.

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@GitHK GitHK self-assigned this Dec 20, 2024
@GitHK GitHK added this to the Event Horizon milestone Dec 20, 2024
@GitHK GitHK marked this pull request as ready for review December 20, 2024 14:32
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GitHK GitHK merged commit 06ad639 into main Dec 23, 2024
4 checks passed
@GitHK GitHK deleted the add-sticky-sessions-to-dynamic-scheduler branch December 23, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants