Changes #10
Open
Changes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the changes @Vaibhavv1703 , would be nice if you could provide some screenshots or screencast videos to show the changes. |
|
|
|
That looks good buddy. Only thing lacking is the login container on the right side. You can see that the thumbnails are overlapping the social media icons. Also, there is no relationship between the social media icons and the "Log in with" statement because the icons are way down there and not within the login container. But the changes are seen and you are going well! |
|
All right, I just wanted to know that. I'll make more changes and then drop a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some changes, please check them out and let me know if I'm going in the right direction