-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add different view modes for resource lists #118
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please clarify a few things:
What are the main changes introduced in this PR?
Is there anything specific you'd like me to review or pay extra attention to?
I've updated the PR description to show the main changes. I think there's nothing specific that requires extra attention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use only one class instead of three (*ListItem, *ListItemMinimal, *ListItemDetailed) to handle the different levels of detail for displaying resource information.
Also use the ViewMode trait in the BaseItemList.php and BaseItemList.php instead of using it in all the other List classes.
I placed the constants in ViewModeSwitcher instead, because I think they fit better there. |
Hide view mode switcher in the Web UI if all view modes are ignored or only one view mode is not ignored.
This PR introduces new view modes for resource lists to enhance the user experience, following the approach used in icingadb-web. The implemantation includes three view modes:
If a resource does not provide sufficient information for a more detailed view, the corresponding options in the view mode switcher will not be available.