Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item-list.less: Always apply calculated   margin to .title content #240

Closed

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@nilmerg
Copy link
Member

nilmerg commented Jan 16, 2025

The margin you're adjusting here is where it is for a reason. It is tightly connected with the .title being a flex container. As such, white space inside it collapses and the margin restores it.

If the margin is always (i.e. also on non-flex containers) applied, it is combined with white space and the resulting gaps are too wide.

The margin rules however, as they currently exist, are applicable to only a very specific structure: <html> text <html> text

Any <html> <html> structure will not work with it. Is this the reason why you wanted to change it?

@sukhwinder33445
Copy link
Contributor Author

I see, the reason for this change is explained here (Line 1-16).

So I should leave it as it is, and the change in the linked file (Line 1-16) is necessary.

@nilmerg
Copy link
Member

nilmerg commented Jan 16, 2025

I saw that comment already, but it doesn't explain why it's required in detailed mode.

@sukhwinder33445
Copy link
Contributor Author

As disscussed offline, this change is not required.

@nilmerg nilmerg deleted the apply-list-item-title-layout-to-every-list branch January 17, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants