This repository has been archived by the owner on Jun 1, 2020. It is now read-only.
Allow the use of a separate ca chain file #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncan-brown
changed the title
duncan-brown
force-pushed
the
cert-chain
branch
2 times, most recently
from
93fe871 to
d85540d
Compare
duncan-brown
force-pushed
the
cert-chain
branch
from
d85540d to
0dc16b3
Compare
|
@skoranda poke on this pull request. |
|
I believe that the image/container you point to also generates the file(s) fullchain.pem, just like the standard 'certbot' utility does. That file contains the end entity certificate and the chain together in one file. Can you use that file instead of needing this patch? The trend for all webservers (including Apache HTTP Server) is to have them all in one file now and I would like to follow that trend if possible. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a
HTTPS_CHAIN_FILEenvironment variable that (optionally) allows the user to specify a CA chain. If this is not given thenHTTPS_CERT_FILEmust contain the full CA chain as well as the certificate, as before.The motivation is because https://github.com/linuxserver/docker-letsencrypt generates separate chain and cert files.