Added check that weapon has ammo in reload_weapon_hotkey. #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this the game would try to reload weapons that did not have ammo, which could cause it to access off the end of the player ammo clips array with strange results.
|
Good find! I assume this means that vanilla system shock for DOS has this same bug? |
Interrupt
approved these changes
Jan 25, 2022
Well @bangstk found it, I just poked about in the debugger a bit. (I never used that hotkey and I always set the Sparq to max power anyway.) DOS Shock and System Shock "Classic" on Steam both exhibit the bug (not surprisingly since I'm pretty sure they're the exact same thing). So it's an oldie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this the game would try to reload weapons that did not have ammo, which could cause it to access off the end of the player ammo clips array with strange results.
Addresses issue #384