Repository navigation
Conversation
Jimbo4350
marked this pull request as ready for review
October 15, 2026 19:06
Jimbo4350
requested review from
carbolymer,
disassembler,
kevinhammond and
palas
as code owners
October 15, 2026 19:06
Jimbo4350
force-pushed
the
fix/cip159-deposit-view
branch
2 times, most recently
from
October 15, 2026 19:12
beadab8 to
d1a6689
Compare
Jimbo4350
force-pushed
the
feature/cip159-account-build-flags
branch
from
October 15, 2026 19:12
7fc8240 to
cea9124
Compare
Jimbo4350
changed the title
carbolymer
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dijkstra transactions built with
--direct-depositcurrently omit the recipient and amount fromdebug transaction view. This renders direct deposits in both JSON and YAML, using the same account and amount format as withdrawals.Stacked on #1469 and targeting
feature/cip159-account-build-flags. The diff contains only the follow-up commit.Adds JSON/YAML golden tests for two recipients and a separate Herald fragment for #1470 with a single-line description.
Validation on GHC 9.12.4:
git diff --checkpassed.No live node submission tests were run.