Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1921 - Remove support for GHC8.10 #1922

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Cmdv
Copy link
Contributor

@Cmdv Cmdv commented Dec 13, 2024

Description

This is the ground works for #1921 we will complete it when cardano-node has also removed 8.10. Also as mentioned in issue we need to make sure the CI works for all versions before removing 8.10.

Fourmolu will fail due to the newer version having a slightly different rules.

edit: ran fourmolu but the main stumbling block is how it changes:

-  pure $
-    SmashServerConfig
+  pure
+    $ SmashServerConfig

so $ is on the new line, looked into turning that off but it's built in there isn't an option for it 🤷

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
doc/installing.md Outdated Show resolved Hide resolved
@Cmdv Cmdv force-pushed the 1921-remove-support-ghc8.10 branch from 83f87e3 to 5b06bf5 Compare December 13, 2024 17:48
@Cmdv Cmdv force-pushed the 1921-remove-support-ghc8.10 branch from e2d4e29 to 9bed37a Compare December 13, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants