Made it possible to use Imp logging in the conformance hook #4796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/impm-forall
branch
5 times, most recently
from
7473e09 to
2ef9678
Compare
Soupstraw
force-pushed
the
jj/impm-forall
branch
from
2ef9678 to
7153f28
Compare
Soupstraw
changed the title
Soupstraw
changed the title
Soupstraw
force-pushed
the
jj/impm-forall
branch
2 times, most recently
from
52f174b to
4099ed1
Compare
Soupstraw
force-pushed
the
jj/impm-forall
branch
from
4099ed1 to
eb365c4
Compare
|
It seems like hydra isn't too happy with this solution for some reason. There are some problems when building with ghc-8.10.7 on hydra CI. 🤷 |
lehins
force-pushed
the
jj/impm-forall
branch
from
eb365c4 to
5798ec5
Compare
Soupstraw
force-pushed
the
jj/impm-forall
branch
from
5798ec5 to
7a2873d
Compare
This reverts commit d99e0cd.
Soupstraw
force-pushed
the
jj/impm-forall
branch
from
7a2873d to
6a9f955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit d99e0cd and add some preprocessor directives to make the project compile with GHC8.
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlupdated (usescripts/gen-hie.sh)