Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Node.js memory limit to 4GB in storybook dockerfile #2590

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Increase Node.js memory limit to 4GB in storybook dockerfile #2590

merged 1 commit into from
Jan 2, 2025

Conversation

kneerose
Copy link
Contributor

Temporary fix

This solution is temporary as we shouldn't exceed the default heap memory limit.

List of changes

  • increase the heap memory limit to 4GB in the storybook

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

mesudip
mesudip approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This should solve the deployment error

@mesudip mesudip merged commit 81509e7 into develop Jan 2, 2025
14 of 19 checks passed
@mesudip mesudip deleted the infra/test-chores branch January 2, 2025 08:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

@kneerose
This PR is in the tag: develop-81509e7bc38f6041bc795a69ea291fc9e78b5877 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

@kneerose
This PR is in the tag: develop-81509e7bc38f6041bc795a69ea291fc9e78b5877 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

@kneerose
This PR is in the tag: develop-81509e7bc38f6041bc795a69ea291fc9e78b5877 , for govtool-backend service

@kneerose kneerose linked an issue Jan 3, 2025 that may be closed by this pull request
🐛 Insufficient Heap Memory During Build #2553
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Insufficient Heap Memory During Build
2 participants
@kneerose @mesudip