-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance push notification state tracking in sd ks #879
base: feature/DEV-719-Support-Firebase-on-the-Swift-SDK
Are you sure you want to change the base?
Enhance push notification state tracking in sd ks #879
Conversation
- When the app is brought to the foreground after being in the background and update the notification permission.
… feature/Dev-716-Enhance-Push-Notification-State-Tracking-in-SDKs * feature/DEV-719-Support-Firebase-on-the-Swift-SDK: Delete sample-apps/swift-sample-app/swift-sample-app/GoogleService-Info.plist updates github repo naming update pointers and changelog Support Firebase on the Swift SDK, add firebase notification integration example in swift sample app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just the hardcoded secret
@@ -17,7 +17,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate, IterableAuthDelegate { | |||
func onAuthTokenRequested(completion: @escaping IterableSDK.AuthTokenRetrievalHandler) { | |||
// ITBL: Set your actual secret. | |||
let jwt = IterableTokenGenerator.generateJwtForUserId( | |||
secret: "", | |||
secret: "b766ecf7eb3f4602b3703309d804c0e8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we hardcode secret here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, It's for testing only I'll remove at and push the commit changes. In AppDelegate I added code for firebase notification for sample application testing and for demo purpose only
Jira Ticket(s)
Description