Repository navigation
test(SDK-617): add unit tests for IterableInboxDataModel - #938
Merged
jferrao-itrbl merged 4 commits intoNov 8, 2026
Merged
Conversation
Cover refresh mapping, fetch failure, date formatting, and IterableApi delegation so inbox data model behaviour stays regression-safe.
|
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on 🛟 Help
|
Add coverage for sortByMostRecent when no comparator is set and split the custom-comparator case from misleading titles (review F1–F2).
jferrao-itrbl
marked this pull request as ready for review
November 6, 2026 09:25
rtlsilva
approved these changes
Nov 6, 2026
rtlsilva
left a comment
rtlsilva
left a comment
There was a problem hiding this comment.
Approved with non-blocking comments
Revert test-only CHANGELOG entry; strengthen refresh comparator and row mapping tests; restoreAllMocks; input-sensitive date mapper coverage.
jferrao-itrbl
deleted the
feature/SDK-617-tests-for-IterableInboxDataModel
branch
November 8, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add Jest coverage for IterableInboxDataModel (refresh, failure path, formatting, IterableApi calls).
🎟️ Jira Ticket: SDK-617
📖 Description
Introduces
src/inbox/classes/IterableInboxDataModel.test.tswithIterableApispies:refresh()applies filter/comparator and maps rows; rejection yields[]; default and custom date mappers; delegation for read, delete, HTML fetch, session start/end (withupdateVisibleRowsordering), andupdateVisibleRows.🧪 How to test?
yarn test src/inbox/classes/IterableInboxDataModel.test.tsyarn lint && yarn typecheck && yarn test --coverage && yarn check:circular🧾 Changelog
No customer facing changes
📹 Loom recording if applicable
N/A
🐞 Github Issues solved
N/A
📚 Docs PR if applicable
N/A