Skip to content

test(SDK-614): add IterableInboxMessageList unit tests - #939

Merged
jferrao-itrbl merged 2 commits into
masterfrom
feature/SDK-614-tests-for-IterableInboxMessageList
Nov 8, 2026
Merged

jferrao-itrbl merged 2 commits into
masterfrom
feature/SDK-614-tests-for-IterableInboxMessageList

Conversation

@jferrao-itrbl

@jferrao-itrbl jferrao-itrbl commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

📝 Summary

Add Jest coverage for inbox message list (cells, impressions, swipe/scroll).

🎟️ Jira Ticket: SDK-614

📖 Description

Introduces IterableInboxMessageList.test.tsx, mocking IterableInboxMessageCell so we can assert FlatList behaviour in isolation: one row per view model, updateVisibleMessageImpressions receives messageId and silentInbox, invalid view tokens are filtered, and scrollEnabled is false while the cell reports swiping.

🧪 How to test?

yarn test src/inbox/components/IterableInboxMessageList.test.tsx

🧾 Changelog

No customer facing changes

📹 Loom recording if applicable

N/A

🐞 Github Issues solved

N/A

📚 Docs PR if applicable

N/A

Cover list rendering, impression callbacks (including silent inbox), invalid
view token filtering, and scroll lock while swiping.
@jferrao-itrbl
jferrao-itrbl requested a review from a team as a code owner November 6, 2026 09:45
@qltysh

qltysh Bot commented Nov 6, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 2.4%.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Lines Statements Branches Functions
Coverage: 76%
75.95% (654/861) 64.37% (262/407) 72.99% (200/274)

Align useEffect deps with exhaustive-deps, assert scroll re-enables after swipe.
@jferrao-itrbl
jferrao-itrbl merged commit 737c551 into master Nov 8, 2026
22 checks passed
@jferrao-itrbl
jferrao-itrbl deleted the feature/SDK-614-tests-for-IterableInboxMessageList branch November 8, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants