Repository navigation
Conversation
…All the menu tests are now together and all open/save tests are together.
…ts dragging from a random place.
…or flattening the object model.
There is possibly a better long term solution where we keep the stereochemistry from the original object without reperceiving it but this functions for now.
We can only have a single accelerator but we can have multiple keystokes mapped directly to the actions, however the mi.getAction() is null and we can't set it so we need pass it in.
…ey to switch functions.
We now only remove carbons, hetero atoms are only removed if all their bonds are removed otherwise they are changed to carbons. This sounds strange but works really nicely and mirrors some other chemical sketchers.
…s fired. Otherwise it is just the key which is pressed (not correct).
… element. Setting the explicit valence clears any charge/isotope and likewise setting the charge clears the valence. Set the default display mode to no terminal -CH3, no longer needed since the user can control it.
|
…merged a bit better.
…h disables merging.
… This included the atoms in the deleted bonds, however the updateAtom() was throwing an error because some atoms may be deleted. We could spend time working which atoms are still around but it's more sane just to return null and update only if non null.
johnmay
marked this pull request as ready for review
October 14, 2026 13:11
johnmay
changed the title
Contributor
Author
|
@egonw need #242 first but this is good for review now. Sorry some bits where I was fixing tests are a bit messy but summary above explains the main functionality. When cdk/cdk#1338 is merge there is an option to enable as well. |
Member
|
Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important! Depends on #242
Currently checking test status on pipeline.
Changes:
atom.getValency()property.Then merge:
The nitrogens are 'kept'.