Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: define fontFace is now face within font object #4325

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

jaliyaudagedara
Copy link
Contributor

Prerequisites

  • I have read and understood the [contributing guide][CONTRIBUTING.md].
  • The commit message follows the [conventional commits][cc] guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Description

Define fontFace is now face within font object.

https://learn.microsoft.com/en-us/windows/terminal/customize-settings/profile-appearance#font-face

@jaliyaudagedara jaliyaudagedara changed the title Patch 1 docs: define fontFace is now face within font object Oct 8, 2023
@JanDeDobbeleer JanDeDobbeleer merged commit ee70988 into JanDeDobbeleer:main Oct 15, 2023
3 checks passed
@JanDeDobbeleer
Copy link
Owner

@all-contributors please add @jaliyaudagedara for doc

This is pure magic 🪄! @holopin-bot @jaliyaudagedara wizard

@holopin-bot
Copy link

holopin-bot bot commented Oct 15, 2023

Congratulations @jaliyaudagedara, you just earned a badge! Here it is: https://holopin.io/claim/clnr3qafo03410fl90gyb4tc7

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@allcontributors
Copy link
Contributor

@JanDeDobbeleer

I've put up a pull request to add @jaliyaudagedara! 🎉

@jaliyaudagedara jaliyaudagedara deleted the patch-1 branch October 15, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants