Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): make JSON generation smarter by using structs #5906

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

vshulcz
Copy link
Contributor

@vshulcz vshulcz commented Nov 18, 2024

Prerequisites

  • I have read and understood the contributing guide.
  • The commit message follows the conventional commits guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features). (Not applicable as this is a test refactor.)

Description

This PR addresses the TODO: // TODO: make this smarter in the test suite of the Brewfather segment. It seems to me better than the previous implementation with manual JSON concatenation and fmt.Sprintf for formatting.

@JanDeDobbeleer JanDeDobbeleer merged commit 7c30729 into JanDeDobbeleer:main Nov 19, 2024
10 checks passed
@JanDeDobbeleer
Copy link
Owner

@all-contributors please add @vshulcz for code

This is pure magic 🪄! @holopin-bot @vshulcz wizard

Copy link

holopin-bot bot commented Nov 19, 2024

Congratulations @vshulcz, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm3oi4smd128510cmdb7hdql74

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Copy link
Contributor

@JanDeDobbeleer

I've put up a pull request to add @vshulcz! 🎉

@vshulcz vshulcz deleted the improve-test-structure branch November 19, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants