Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello #6

Closed
wants to merge 13 commits into from
Closed

Hello #6

wants to merge 13 commits into from

Conversation

Dosx001
Copy link

@Dosx001 Dosx001 commented Jan 19, 2021

Hey, I haven't heard from you. I tried getting in contact with you through Linkedin but you haven't responded. I did ping you in the other pull request but no luck there. The only way I have been able to get in contact with you is with pull requests so here is another one lol.

I still want to work on this project, but I've just been busy working on other projects. There are a few more features I want to add and create some safety nets for the user.

So check out some of the changes I made in the other pull request. They're some pretty cool changes and give your feedback. 😃

Dosx001 added 13 commits January 2, 2021 17:45
just static commands. For example when you create something like this "al add
new 'cd'". Then when you run "al new root/directory" then it will change your
directory to "../root/directory" or anything base on your input.
… alias where

you can change its' contents per call
functions were modify to accommodate for cmdType. However autocomplete is broken.
…l is now is a combination of Fill and Dynamic
@Jintin
Copy link
Owner

Jintin commented Jan 19, 2021

Thanks for following up, ya, actually I saw your message on linkedin but soon the message is gone so I guess you delete it on your end? or still working on something. Maybe you can ping me again and let's add friend?

The problem for me is the message on this change is too massive to catch up, for example you create several pr and keep pushing things into it and also with the discussion or progress update. It's a bit hard to keep an eye on every change you made. But I do really appreciate your contribute. Maybe just let me know when you finish on your idea? or let's do it step by step if you have several improve idea?

@Jintin
Copy link
Owner

Jintin commented Jan 19, 2021

And now which pr should I look at for example?

@Jintin Jintin self-requested a review January 19, 2021 07:57
@Dosx001
Copy link
Author

Dosx001 commented Jan 19, 2021

@Jintin Just look at pr #4. That's where all my comments and commits are at. Can you send me a request on LinkedIn? I can't resend my request.

Here's my LinkedIn https://www.linkedin.com/in/andresrodriguezmichel/

@Jintin
Copy link
Owner

Jintin commented Jan 20, 2021

Screen Shot 2021-01-20 at 11 33 48 AM

The notify still not work but I manually check this time. And linkedIn seems hard to use as well can you see my message on linkedIn?

@Dosx001 Dosx001 closed this Jan 20, 2021
@Dosx001 Dosx001 reopened this Jan 20, 2021
@Dosx001 Dosx001 closed this Jan 20, 2021
@Dosx001 Dosx001 deleted the hello branch April 7, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants