Skip to content

Commit

Permalink
fix: remove unnecessary default values from .all-contributorsrc (#1784)
Browse files Browse the repository at this point in the history
## PR Checklist

- [x] Addresses an existing open issue: fixes #1783
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Straightforward removal of config settings. Note the lack of actual
changes to the `README.md` file.

🔪
  • Loading branch information
JoshuaKGoldberg authored Dec 20, 2024
1 parent c13be58 commit a4257e5
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 29 deletions.
12 changes: 1 addition & 11 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
{
"badgeTemplate": "\t<a href=\"#contributors\" target=\"_blank\"><img alt=\"👪 All Contributors: <%= contributors.length %>\" src=\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\" /></a>",
"commit": false,
"commitConvention": "angular",
"commitType": "docs",
"contributors": [
{
"avatar_url": "https://avatars.githubusercontent.com/u/3335181?v=4",
Expand Down Expand Up @@ -483,14 +480,7 @@
]
}
],
"contributorsPerLine": 7,
"contributorsSortAlphabetically": true,
"files": [
"README.md"
],
"imageSize": 100,
"projectName": "create-typescript-app",
"projectOwner": "JoshuaKGoldberg",
"repoHost": "https://github.com",
"repoType": "github"
"projectOwner": "JoshuaKGoldberg"
}
4 changes: 2 additions & 2 deletions src/next/blocks/blockAllContributors.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe("blockAllContributors", () => {
},
],
"files": {
".all-contributorsrc": "{"badgeTemplate":"\\t<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"👪 All Contributors: <%= contributors.length %>\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" /></a>","commit":false,"commitConvention":"angular","commitType":"docs","contributors":[],"contributorsPerLine":7,"contributorsSortAlphabetically":true,"files":["README.md"],"imageSize":100,"projectName":"test-repository","projectOwner":"test-owner","repoHost":"https://github.com","repoType":"github"}",
".all-contributorsrc": "{"badgeTemplate":"\\t<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"👪 All Contributors: <%= contributors.length %>\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" /></a>","contributors":[],"contributorsSortAlphabetically":true,"projectName":"test-repository","projectOwner":"test-owner"}",
".github": {
"workflows": {
"contributors.yml": "jobs:
Expand Down Expand Up @@ -88,7 +88,7 @@ describe("blockAllContributors", () => {
},
],
"files": {
".all-contributorsrc": "{"badgeTemplate":"\\t<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"👪 All Contributors: <%= contributors.length %>\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" /></a>","commit":false,"commitConvention":"angular","commitType":"docs","contributors":[{"avatar_url":"https://avatars.githubusercontent.com/u/3335181?v=4","contributions":["bug","ideas"],"login":"JoshuaKGoldberg","name":"Josh Goldberg","profile":"http://www.joshuakgoldberg.com"}],"contributorsPerLine":7,"contributorsSortAlphabetically":true,"files":["README.md"],"imageSize":100,"projectName":"test-repository","projectOwner":"test-owner","repoHost":"https://github.com","repoType":"github"}",
".all-contributorsrc": "{"badgeTemplate":"\\t<a href=\\"#contributors\\" target=\\"_blank\\"><img alt=\\"👪 All Contributors: <%= contributors.length %>\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" /></a>","contributors":[{"avatar_url":"https://avatars.githubusercontent.com/u/3335181?v=4","contributions":["bug","ideas"],"login":"JoshuaKGoldberg","name":"Josh Goldberg","profile":"http://www.joshuakgoldberg.com"}],"contributorsSortAlphabetically":true,"projectName":"test-repository","projectOwner":"test-owner"}",
".github": {
"workflows": {
"contributors.yml": "jobs:
Expand Down
8 changes: 0 additions & 8 deletions src/next/blocks/blockAllContributors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,10 @@ export const blockAllContributors = base.createBlock({
".all-contributorsrc": JSON.stringify({
badgeTemplate:
' <a href="#contributors" target="_blank"><img alt="👪 All Contributors: <%= contributors.length %>" src="https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg" /></a>',
commit: false,
commitConvention: "angular",
commitType: "docs",
contributors: options.contributors ?? [],
contributorsPerLine: 7,
contributorsSortAlphabetically: true,
files: ["README.md"],
imageSize: 100,
projectName: options.repository,
projectOwner: options.owner,
repoHost: "https://github.com",
repoType: "github",
}),
".github": {
workflows: {
Expand Down
8 changes: 0 additions & 8 deletions src/steps/writing/creation/writeAllContributorsRC.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,9 @@ export async function writeAllContributorsRC(options: Options) {
return await formatJson({
badgeTemplate:
' <a href="#contributors" target="_blank"><img alt="👪 All Contributors: <%= contributors.length %>" src="https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg" /></a>',
commit: false,
commitConvention: "angular",
commitType: "docs",
contributors: existing?.contributors ?? [],
contributorsPerLine: 7,
contributorsSortAlphabetically: true,
files: ["README.md"],
imageSize: 100,
projectName: options.repository,
projectOwner: options.owner,
repoHost: "https://github.com",
repoType: "github",
});
}

0 comments on commit a4257e5

Please sign in to comment.