fix: corrected names and with

JoshuaKGoldberg · Aug 10, 2024 · ed461fe · ed461fe
1 parent 2410b07
commit ed461fe
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ jobs:
       - run: pnpm build
       - run: pnpm lint
   lint_knip:
-    name: Lint_knip
+    name: Lint Knip
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4

diff --git a/src/steps/writing/creation/dotGitHub/createMultiWorkflowFile.ts b/src/steps/writing/creation/dotGitHub/createMultiWorkflowFile.ts
@@ -1,6 +1,8 @@
 import { formatWorkflowYaml } from "./formatWorkflowYaml.js";
 
-export type MultiWorkflowJobStep = { run: string } | { uses: string };
+export type MultiWorkflowJobStep =
+	| { run: string }
+	| { uses: string; with?: Record<string, string> };
 
 export interface MultiWorkflowJobOptions {
 	name: string;
@@ -29,7 +31,6 @@ export function createMultiWorkflowFile({
 						{ uses: "./.github/actions/prepare" },
 						...job.steps,
 					],
-					with: job.with,
 				},
 			]),
 		),

diff --git a/src/steps/writing/creation/dotGitHub/createWorkflows.test.ts b/src/steps/writing/creation/dotGitHub/createWorkflows.test.ts
@@ -105,7 +105,7 @@ describe("createWorkflows", () => {
 			      - uses: ./.github/actions/prepare
 			      - run: pnpm lint:packages
 			  lint_spelling:
-			    name: Lint spelling
+			    name: Lint Spelling
 			    runs-on: ubuntu-latest
 			    steps:
 			      - uses: actions/checkout@v4
@@ -126,8 +126,8 @@ describe("createWorkflows", () => {
 			      - uses: ./.github/actions/prepare
 			      - run: pnpm run test --coverage
 			      - uses: codecov/codecov-action@v3
-			    with:
-			      flags: unit
+			        with:
+			          flags: unit
 			  type_check:
 			    name: Type Check
 			    runs-on: ubuntu-latest

diff --git a/src/steps/writing/creation/dotGitHub/createWorkflows.ts b/src/steps/writing/creation/dotGitHub/createWorkflows.ts
@@ -77,7 +77,7 @@ export function createWorkflows(options: Options) {
 					? []
 					: [
 							{
-								name: "Lint spelling",
+								name: "Lint Spelling",
 								steps: [{ run: "pnpm lint:spelling" }],
 							},
 						]),
@@ -88,11 +88,13 @@ export function createWorkflows(options: Options) {
 								name: "Test",
 								steps: [
 									{ run: "pnpm run test --coverage" },
-									{ uses: "codecov/codecov-action@v3" },
+									{
+										uses: "codecov/codecov-action@v3",
+										with: {
+											flags: "unit",
+										},
+									},
 								],
-								with: {
-									flags: "unit",
-								},
 							},
 						]),
 			],