fix: don't include chore PRs in changelog #1810
Conversation
michaelfaith
force-pushed
the
fix/dont-include-chore-changes-in-changlog
branch
from
aaf3f02 to
01a55e2
Compare
This change adjusts the release-it config for both this repo, as well as what the create script generates, so that only three categories of changes are included in the changelog entries: feat, fix, and perf. The idea being that these are the only three types of changes that are generally user-facing.
michaelfaith
force-pushed
the
fix/dont-include-chore-changes-in-changlog
branch
from
01a55e2 to
7e859df
Compare
package.json
Outdated
| "test:create": "npx tsx script/create-test-e2e.ts", | ||
| "test:initialize": "npx tsx script/initialize-test-e2e.ts", | ||
| "test:create": "tsx script/create-test-e2e.ts", | ||
| "test:initialize": "tsx script/initialize-test-e2e.ts", |
There was a problem hiding this comment.
fyi @michaelfaith I removed these changes before merging - but if you think they're good I'm interested in learning more
There was a problem hiding this comment.
yeah, no worries. That was unrelated. I thought it might have been missed in some repo migration from npm to pnpm. It seemed strange that everything used pnpm except for these two scripts, which didn't really need npx either, since tsx is installed locally. Unless you're wanting to allow people to run those scripts without needing to install pnpm or any dependencies? But yeah, it was unrelated to this change; just something I noticed, while testing the changes I made.
| { "hidden": true, "type": "docs" }, | ||
| { "hidden": true, "type": "refactor" }, | ||
| { "hidden": true, "type": "style" }, | ||
| { "hidden": true, "type": "test" } |
There was a problem hiding this comment.
[Praise] I appreciate you alphabetizing these 😁
|
@all-contributors please add @michaelfaith for code.
|
|
I've put up a pull request to add @michaelfaith! 🎉 |
Adds @michaelfaith as a contributor for code. This was requested by JoshuaKGoldberg [in this comment](#1810 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
PR Checklist
status: accepting prsOverview
This change adjusts the release-it config for both this repo, as well as what the create script generates, so that only three categories of changes are included in the changelog entries: feat, fix, and perf. The idea being that these are the only three types of changes that are generally user-facing.
Tested locally with some dummy
chorecommits that I undid after.Closes: #1493