Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace existing description with string, not regex #861

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: replace existing description with string, not regex #861

merged 1 commit into from
Sep 21, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 21, 2023 •
edited
Loading

PR Checklist

Overview

Applies two tangentially related fixes:

  • The original description can be replaced with a plain string - it doesn't need a regular expression
  • The rerun suggestion for descriptions should escape $s

github-actions[bot]
github-actions bot reviewed Sep 21, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@JoshuaKGoldberg JoshuaKGoldberg merged commit dcc6ad4 into main Sep 21, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the description-string-not-regex branch September 21, 2023 17:53
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: SyntaxError on description with regexp characters
1 participant
@JoshuaKGoldberg