-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more parameters to control fitting, and add data checks #24
Conversation
I feel that using
I find it unnecessary to use |
I'm sorry for the late reply. I forgot about this PR.
Hmm yes good point I guess. |
Co-authored-by: Rik Huijzer <[email protected]>
Thank you @OkonSamuel for this extend sequence of PRs and @rikhuijzer for the informed reviews. ❤️ |
This PR add several checks on the dataset. One of such checks is to make sure that the dataset doesn't contain more features than observations (i.e the dataset isn't wide). This PR also throws an informative error message for some hidden errors due to flawed
offsetcol
logic. For example, users were previously allowed (maybe unintentionally) to choose an offset column that wasn't among the features of the training dataset, leading to confusing errors.cc. @ablaom , @rikhuijzer