Line limit to 120 #78

Activity

1. iamed2 commented on Nov 11, 2020

   

   iamed2

   on Nov 11, 2020

   Collaborator

   More actions

   I can only hit 112, not 120.

   I think 100 would be best.

   👍React with 👍1Reacted by Rory Finnegan
2. mattBrzezinski commented on Nov 12, 2020

   

   mattBrzezinski

   on Nov 12, 2020

   MemberAuthor

   More actions

   I'll take anything, do others have thoughts?
3. fchorney commented on Nov 12, 2020

   

   fchorney

   on Nov 12, 2020

   Contributor

   More actions

   I think 120 is a little bit much. So I'd compromise to 100
4. nickrobinson251 commented on Nov 12, 2020

   

   nickrobinson251

   on Nov 12, 2020

   Last edited by nickrobinson251

   Contributor

   More actions

   i'd be a little bit interested in knowing what effect this has in terms of reducing line breaks.
   JuliaFormatter has a BlueStyle and let's you configure line length (via the margin keyword e.g. format("path/to/src/", BlueStyle(); margin=N), so we could see across a bunch of different packages how changing N changes the total number of line breaks?

   👍React with 👍3Reacted by Frames White, Eric Davies and Fernando Chorney
5. nickrobinson251

   added

   questionFurther information is requestedFurther information is requested

   on Nov 18, 2020
6. zsz00 commented on Oct 14, 2021

   

   zsz00

   on Oct 14, 2021

   More actions

   I'd propose increasing this line length to 120 !!
7. omus commented on Feb 17, 2022

   

   omus

   on Feb 17, 2022

   Contributor

   More actions

   If I recall correctly the original reason 92 was chosen was because it is the line length limit specified by the Julia contribution guide.
8. mattBrzezinski commented on Feb 17, 2022

   

   mattBrzezinski

   on Feb 17, 2022

   MemberAuthor

   More actions

   If I recall correctly the original reason 92 was chosen was because it is the line length limit specified by the Julia contribution guide.

   The commit for this was made 7 years ago, maybe it's time to revisit? 😄
9. mattBrzezinski commented on May 16, 2022

   

   mattBrzezinski

   on May 16, 2022

   MemberAuthor

   More actions

   i'd be a little bit interested in knowing what effect this has in terms of reducing line breaks. JuliaFormatter has a BlueStyle and let's you configure line length (via the margin keyword e.g. format("path/to/src/", BlueStyle(); margin=N), so we could see across a bunch of different packages how changing N changes the total number of line breaks?

   Just got brought up in the office again. I went through all the packages below and ran format(".", BlueStyle()) did a git add ., then re-ran format(".", BlueStyle(); margin=100) (only 100 since it seemed more agreed upon from previous discussions). These are the results of the following git diff --shortstat:

   • BlockDiagonals.jl: 4 files changed, 9 insertions(+), 22 deletions(-)
   • ChainRules.jl: 4 insertions(+), 10 deletions(-)
   • CompatHelper.jl: 13 files changed, 39 insertions(+), 117 deletions(-)
   • Intervals.jl: 11 files changed, 58 insertions(+), 155 deletions(-)
   • OrderedCollections.jl: 6 files changed, 23 insertions(+), 63 deletions(-)
10. Wynand commented on May 18, 2022

    

    Wynand

    on May 18, 2022

    Last edited by Wynand

    More actions

    I'm not a linguist or typographer, but 92 characters seems fine with a few assumptions by taking
    (things on the line) * (max length of each thing) + (connectors between things) as an equation for line length

    If you assume most people can keep 5-9 things in mind at a time, that indentation is some of those things, and if you really stretch it an assume that the length limit for remembering a word is between 5 and 9, then the upper limit on that is actually (9*9 + 8) = 89

    I think 89 is short, especially considering that the 7 +- 2 rule is outdated (though 4 +- 1 is apparently more accurate) (https://en.wikipedia.org/wiki/Short-term_memory#Capacity), but it suggests that 92 characters is long enough
11. iamed2 commented on May 19, 2022

    

    iamed2

    on May 19, 2022

    Collaborator

    More actions

    @Wynand one of the most common things, AbstractArray, is of length 13. As you have more functions in your codebase, the length of the things are probably going to increase. If you look at the top-level symbols in Base, the average size is greater than 11:

    julia> mean(length∘String, names(Base; all=true, imported=true))
    11.476996687523004
    

    (a better measurement could be done with a parser rather than just looking at the top level)

    @mattBrzezinski can you show those diffs? it might be interesting as a sample of lines that are impacted by the current line length limit.