-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof Slicing: make dependency tracking optional #3309
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3309 +/- ##
============================================
- Coverage 37.79% 37.79% -0.01%
- Complexity 16844 16857 +13
============================================
Files 2051 2052 +1
Lines 125329 125566 +237
Branches 21190 21249 +59
============================================
+ Hits 47370 47456 +86
- Misses 72121 72272 +151
Partials 5838 5838
... and 87 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
... if the dependency tracker isn't always on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your effort. Please find some remarks that are hopefully useful.
keyext.slicing/src/main/java/org/key_project/slicing/DependencyTracker.java
Show resolved
Hide resolved
keyext.slicing/src/main/java/org/key_project/slicing/DependencyTracker.java
Show resolved
Hide resolved
keyext.slicing/src/main/java/org/key_project/slicing/DependencyTracker.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #3301 by adding an option to disable the dependency tracker and adding a way to create the dependency graph after the proof is done.
cc @unp1