-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackeython/error reporting #3432
Conversation
…nation. The issue occurred when there was code (class declaration) between two comments parented to the class.
spotless formatting
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3432 +/- ##
============================================
+ Coverage 37.87% 37.88% +0.01%
- Complexity 17083 17089 +6
============================================
Files 2092 2092
Lines 127520 127596 +76
Branches 21466 21478 +12
============================================
+ Hits 48298 48343 +45
- Misses 73316 73332 +16
- Partials 5906 5921 +15 ☔ View full report in Codecov by Sentry. |
This PR will also fix #3441 |
Ping for a review, @WolframPfeifer. Thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR in general enhances the error messages. While I did not check all the parser message test cases, I think the fact that there is an infrastructure to ensure that in certain cases specific messages are thrown is an improvement.
The PR is also nicely documented, however, I pointed out a few places where comments and the tags are inconsistent. However, as this is no functional problem and the PR is already waiting very long, I think we can merge this now and update the 3 comments later.
key.core/src/test/resources/de/uka/ilkd/key/nparser/exceptional/doubleDecl2.key
Outdated
Show resolved
Hide resolved
key.core/src/test/resources/de/uka/ilkd/key/speclang/njml/exceptional/Bevhavioural.java
Outdated
Show resolved
Hide resolved
...core/src/test/resources/de/uka/ilkd/key/speclang/njml/exceptional/NamedAccessInContract.java
Outdated
Show resolved
Hide resolved
5f41f1f
to
30afba3
Compare
This brings the edits from the error reporting group at the hackeython onto the main branch
Intended Change
Have better parser message.
The code driving the parsers has been adapted. Also the code that produces the JML code to parse had to be adapted to contain the correct spaces. Moreover, message extraction from ANTLR exception classes has been improved.
Type of pull request
Ensuring quality
Additional information and contact(s)
Collaboration with @FliegendeWurst @MarcoScaletta @LennartKleinwort
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.