Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackeython/error reporting #3432

Merged
merged 28 commits into from
Apr 15, 2024
Merged

Hackeython/error reporting #3432

merged 28 commits into from
Apr 15, 2024

Conversation

mattulbrich
Copy link
Member

This brings the edits from the error reporting group at the hackeython onto the main branch

Intended Change

Have better parser message.

The code driving the parsers has been adapted. Also the code that produces the JML code to parse had to be adapted to contain the correct spaces. Moreover, message extraction from ANTLR exception classes has been improved.

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (behaviour should not change or only minimally change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • There are changes to the (Java) code
  • There are changes to the taclet rule base
  • There are changes to the deployment/CI infrastructure (gradle, github, ...)
  • Other:

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I made sure that new/changed end-user features are well documented (https://github.com/KeYProject/key-docs).
  • I added new test case(s) for new functionality.
  • I have tested the feature as follows: ...
  • I have checked that runtime performance has not deteriorated.

Additional information and contact(s)

Collaboration with @FliegendeWurst @MarcoScaletta @LennartKleinwort

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 37.88%. Comparing base (9cc569c) to head (1088e18).

❗ Current head 1088e18 differs from pull request most recent head 30afba3. Consider uploading reports for the commit 30afba3 to get more accurate results

Files Patch % Lines
...main/java/de/uka/ilkd/key/util/ExceptionTools.java 67.34% 11 Missing and 5 partials ⚠️
...e/uka/ilkd/key/java/recoderext/JMLTransformer.java 85.71% 0 Missing and 2 partials ⚠️
...in/java/de/uka/ilkd/key/nparser/ParsingFacade.java 50.00% 2 Missing ⚠️
...de/uka/ilkd/key/speclang/jml/JMLSpecExtractor.java 88.23% 0 Missing and 2 partials ⚠️
...a/ilkd/key/nparser/builder/DeclarationBuilder.java 50.00% 1 Missing ⚠️
...e/uka/ilkd/key/nparser/builder/DefaultBuilder.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3432      +/-   ##
============================================
+ Coverage     37.87%   37.88%   +0.01%     
- Complexity    17083    17089       +6     
============================================
  Files          2092     2092              
  Lines        127520   127596      +76     
  Branches      21466    21478      +12     
============================================
+ Hits          48298    48343      +45     
- Misses        73316    73332      +16     
- Partials       5906     5921      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FliegendeWurst
Copy link
Member

This PR will also fix #3441

@mattulbrich
Copy link
Member Author

Ping for a review, @WolframPfeifer. Thx.

@mattulbrich mattulbrich added the Review Request Waiting for review label Mar 26, 2024
Copy link
Member

@WolframPfeifer WolframPfeifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR in general enhances the error messages. While I did not check all the parser message test cases, I think the fact that there is an infrastructure to ensure that in certain cases specific messages are thrown is an improvement.

The PR is also nicely documented, however, I pointed out a few places where comments and the tags are inconsistent. However, as this is no functional problem and the PR is already waiting very long, I think we can merge this now and update the 3 comments later.

@mattulbrich mattulbrich enabled auto-merge April 10, 2024 13:56
@mattulbrich mattulbrich force-pushed the hackeython/error-reporting branch 3 times, most recently from 5f41f1f to 30afba3 Compare April 14, 2024 22:27
@mattulbrich mattulbrich added this pull request to the merge queue Apr 14, 2024
Merged via the queue into main with commit 7254776 Apr 15, 2024
26 of 45 checks passed
@mattulbrich mattulbrich deleted the hackeython/error-reporting branch April 15, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Request Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants