Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposing a more flexible lexing framework #3537

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mattulbrich
Copy link
Member

@mattulbrich mattulbrich commented Jan 17, 2025

Intended Change

The syntax highlighting framework in the issue dialog makes the cursor jump around a lot. It does not support KeY files for the moment.

Plan

  • Make the "JavaDocument" language-independent
  • Implement a corr. Java lexer
  • Implement a corr. KeY parser
  • Document the changes
  • (optional) Make sure the realtime colour update works with the Java version since that may be configured at runtime

The code is there can be reused from other places.

Type of pull request

  • Refactoring (behaviour should not change or only minimally change). Actually improvements in the error editor windows.
  • New feature (non-breaking change which adds functionality)
  • There are changes to the (Java) code
  • There are minor improvements in the UI

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I have tested the feature as follows: tried it out.

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

@mattulbrich mattulbrich added JML Parser GUI KeY Parser Feature New feature or request Error Reporting Missing file/position info for parse errors, uncaught errors, wrong/unclear messages, ... labels Jan 17, 2025
@mattulbrich mattulbrich self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.19%. Comparing base (cfd8f0f) to head (393374a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3537      +/-   ##
============================================
- Coverage     38.19%   38.19%   -0.01%     
+ Complexity    17228    17227       -1     
============================================
  Files          2111     2111              
  Lines        127642   127642              
  Branches      21463    21463              
============================================
- Hits          48750    48749       -1     
- Misses        72903    72904       +1     
  Partials       5989     5989              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wadoon
Copy link
Member

wadoon commented Jan 18, 2025

There was a branch (weigl/editor or so), where I had robust editors on the RSyntaxArea component.

@mattulbrich Should/Does the highlighting respect the current JML active (conditional) tags?

@wadoon wadoon added this to the v2.12.4 milestone Jan 18, 2025
@wadoon
Copy link
Member

wadoon commented Jan 18, 2025

One thing I could find here:

https://git.key-project.org/key/key/-/merge_requests/341

I also found the integrative swing editor with support PSDBG on branch weigl/Scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Missing file/position info for parse errors, uncaught errors, wrong/unclear messages, ... Feature New feature or request GUI JML Parser KeY Parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants