fix: update encoding output of install.ps1 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ryouji <[email protected]>
|
Still working on this, will test on more devices tomorrow |
|
Tested, works properly on:
Does not work on:
At least we successfully support Unicode mode, without making anything worse |
|
I tried to force Windows Powershell to print in Unicode mode: [Console]::OutputEncoding = [System.Text.Encoding]::UTF8This works fine on Windows 11 ANSI mode, but crashes on Windows 7 ANSI mode |
Keldos-Li
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments in #144
cc @soryu-ryouji