Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: total row count for selection went up when grouping #1343

Closed
wants to merge 1 commit into from

Conversation

fredericbahr
Copy link
Contributor

Beforehand the total row count went up when grouping.

This is fixed by using the core row modal as none transformation has happend. From my understanding this will always give the amount of possible rows to select as this is the max amount of rows given to the table.

Fixes: #1227

Beforehand the total row count went up when grouping.

This is fixed by using the core row modal as none transformation has happend. From my understanding this will always give the amount of possible rows to select as this is the max amount of rows given to the table.

Fixes: KevinVandy#1227
Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
material-react-table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 5:19pm
material-react-table-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 5:19pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total rows not tally when selecting rows when grouping is active
1 participant