-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add URI test assets #157
base: main
Are you sure you want to change the base?
Add URI test assets #157
Conversation
Thanks for the tests. Although it's a very useful set of assets, it needs a bit more polish.
There are several Validator builds (web drag-n-drop, npm, and native) and resource access may be platform-dependent. Quick testing results: Native
Web drag-n-drop
NPM (as in VS Code)
|
A clearer description of each asset would be nice, including the name and what exacty the asset tests or demonstrates, e.g.
The naming of the files is somewhat inconsistent. We should consider using the same naming conventions as for the other models, even when the actual assets are contained in a subfolder. For example, the A consistency nitpick: The other file names. There are An aside: I think that this is the only model so far where the actual models are contained in subfolders. In some way this is similar to the "Compare..." assets that have been added via #136 , and where one could make a case for "grouping" them. But here, having them in one "top-level" directory probably makes sense. ....🤞 hoping that this for itself doesn't cause trouble for the CI Python scripts and generated pages. While I generally see the point of using non-ASCII characters (to give some sense to the different forms of encoding them in the URIs), I wonder whether the names really have to be EDIT: The textures would be smaller if they were stored as PNG. (Not a big deal, though...) |
c4fd3df
to
566aa9a
Compare
This PR adds various test assets for URIs after I noticed that the allowed formats in the glTF spec include percentage encoding, JSON-string escaping and regular UTF8 strings.
The test assets currently break when dropped in almost all implementations, including the Khronos Sample Viewer. The glTF Validator is able to validate most of them as correct, but not all of them (URIs traversing into parent directories can't be validated it seems).
I included ZIP files for convenient download for testing.