-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second Sync Update #86
base: main
Are you sure you want to change the base?
Conversation
All of the models listed in this PR all need descriptions. Most were supplied by UX3D. Tagging a few UX3D people to attract their attention. The model description can be added as a comment and I will get it into the system. You can also create a PR against the forked branch if it is a substantial change. @UX3D-becher , @UX3D-haertl , @UX3D-kanzler Model READMEs (from the PR source) |
@javagl, @lexaknyazev : The SuzanneMorphSparse model needs a description. Can either of you provide something simple for this? |
Maybe this was already supposed to be reviewed, and I missed it, but I'd suggest to not include
I don't know where the screenshot GIF comes from, but none of the common viewers that I tried shows anything "animated" there. (That small white thing that appears (in the GIF) in the lower left when the eyes are closed are a minor detail at this point...) I know that this means that #61 will remain open, but... that's what it is for now. |
Those are actually spec-suggested, see the note at the end of the Morph Targets spec section. Agreed with all other points. There's also inconsistent indentation in |
Changed to Draft so comments can be resolved without merging. |
The models added here need some assistance - mostly descriptions. This is meant to be applied after PR #85 and after the 'issues' tag has been removed.
The new models in this PR are:
In addition other models may have had various updates to READMEs to improve the formatting.