updated dependencies/plugins; plus junit updates #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the update for JUnit, there were some breaking changes "Assert" vs. "Assertions", for example. These changes were done to reflect the dependency upgrades. There were no "assertTrue" methods anymore, so these were updated to failures in most cases. I included the exceptions in the
fail()
calls, but we could also simply use the original message, if desired.Also organized the imports in a few places and removed unused ones.
I originally updated the Java version to 17 which is the most recent LTS.
However, I opted to keep it at Java 8 for now because I did not know if there was a reason to keep it at that version. If there is no reason not to move to 17, then I can update the README to point to where to download Java 17 (probably Adoptium's releases who have JDKs and "JREs" which are really stripped-down JDKs).OpenAPI's generator appears to have a Java 11 requirement. It all builds locally fine so I only noticed after pushing to Github. I made updates to reflect the need for Java 11.