Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venado build #1782

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Venado build #1782

wants to merge 3 commits into from

Conversation

pguthrey
Copy link

@pguthrey pguthrey commented Jan 3, 2025

Summary

Build system work for LANL's Grace Hopper machine, Venado. Thanks @white238 for the help.

  • This PR is a feature
  • It does the following (modify list as needed):
    • Provides a host-config and build script for LANL's Venado machine

Design review (for API changes or additions---delete if unneeded)

On (date), we reviewed this PR. We discussed the design ideas:

  1. First idea or goal
  2. Second idea
  3. Third idea

This PR implements 1. and 3. It leaves out 2. for the following reasons

  • (impractical)
  • (too big)
  • (not a good idea anyway)

@MrBurmark MrBurmark requested a review from a team January 10, 2025 18:56
Copy link
Member

@MrBurmark MrBurmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This puts more setting of options and configuring paths in the host-config rather than the script which is a little different than how we've done things before. @rhornung67 what do you think about this direction?

Comment on lines +54 to +57
echo " Please note that you have to disable CUDA GPU hooks when you run"
echo " the RAJA tests; for example,"
echo
echo " make test"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there supposed to be something else in the example here apart from make test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. Our other nvcc scripts have something like this: https://github.com/LLNL/RAJA/blob/develop/scripts/lc-builds/blueos_nvcc_gcc.sh#L63

@rhornung67
Copy link
Member

This puts more setting of options and configuring paths in the host-config rather than the script which is a little different than how we've done things before. @rhornung67 what do you think about this direction?

@MrBurmark I think keeping as much in the script as possible is best for flexibility. When things are hard-wired in the host-config, you have to edit that file to change something. In general, I think scripts with args and instructions with examples are best. Even if something is hardwired in the script file, it's easier to modify than finding the host-config and editing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants