Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Performance Test Bugfix #323

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

CI Performance Test Bugfix #323

wants to merge 15 commits into from

Conversation

ldowen
Copy link
Collaborator

@ldowen ldowen commented Jan 6, 2025 •
edited
Loading

Summary

  • This PR is a bugfix for the CI performance tests.
  • It does the following:
    • Prevents cleanup from occurring while CI performance tests are running.
    • Ensures performance tests create their own allocation instead of using the CI batch option.
    • Fixes a bug with quotation marks for BlueOS job launches using spheral-ats.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#121)
  • LLNLSpheral PR has passed all tests.

@ldowen ldowen requested review from jmikeowen and mdavis36 January 6, 2025 17:46
@ldowen ldowen self-assigned this Jan 6, 2025
@ldowen ldowen changed the title Bugfix/perf ci CI Performance Test Bugfix Jan 6, 2025
@ldowen ldowen added this to the 2025.01.0 Release milestone Jan 14, 2025
jmikeowen
jmikeowen approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdavis36 mdavis36 mdavis36 approved these changes

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees

@ldowen ldowen

Labels
None yet
Projects
None yet
Milestone
2025.01.0 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ldowen @jmikeowen @mdavis36