Bugfix/find magma #356
Merged
Bugfix/find magma #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balos1
requested review from
gardner48,
cswoodward and
drreynolds
as code owners
gardner48
requested changes
Oct 25, 2023
Co-authored-by: David Gardner <[email protected]>
gardner48
previously approved these changes
Oct 25, 2023
drreynolds
previously approved these changes
Oct 26, 2023
gardner48
reviewed
Oct 26, 2023
gardner48
approved these changes
Oct 26, 2023
balos1
added a commit
that referenced
this pull request
Nov 1, 2023
Always append hipblas and hipsparse CMake targets with HIP backend as these libraries are not reliably included in the pkgconfig file. Replace cublas and cusparse with the CMake targets because the library path in the pkgconfig file is not reliable. Specifically, the path is wrong on systems using the NVIDIA HPC SDK. --------- Co-authored-by: David Gardner <[email protected]>
balos1
added a commit
that referenced
this pull request
Dec 18, 2023
Always append hipblas and hipsparse CMake targets with HIP backend as these libraries are not reliably included in the pkgconfig file. Replace cublas and cusparse with the CMake targets because the library path in the pkgconfig file is not reliable. Specifically, the path is wrong on systems using the NVIDIA HPC SDK. --------- Co-authored-by: David Gardner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the xSDK release.