Repository navigation
Conversation
Contributor
Reviewer's GuideThe PR extends temperature-response spectra loading with a lazily downloaded, verified CHIANTI 11.0.2 source generated by fiasco while preserving the SolarSoft default and restricting chiantifix to SolarSoft data. Tests compare CHIANTI 11 responses against independent references, and the example documents the differing 94 Å behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
nabobalis
force-pushed
the
chianti11-spectra
branch
from
October 20, 2026 22:37
be12f61 to
efc530c
Compare
nabobalis
added this pull request to stack #444
October 20, 2026 22:51
get_source_spectra(source="chianti11") loads an emissivity computed from CHIANTI 11.0.2 with fiasco on backup-files; the chiantifix is refused for it.
nabobalis
force-pushed
the
chianti11-spectra
branch
from
October 21, 2026 01:31
efc530c to
3873d3d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #443.
Summary
The loader is shared: the file decides. A CHIANTIFIX extension means the SolarSoft file (rescaled by 12398/hc, chiantifix in
meta); without one,temperature_response(..., chiantifix=True)is refused.The CHIANTI 11 file boosts both members of the He II 304 Å doublet by 20, as SolarSoft's
aia_bp_make_emissintends; SolarSoft's V9 file boosts only the weak member (its exact-wavelength match for the strong one failed on CHIANTI 9; V6 and V8 boosted both), so its 304 Å response is 2.7× low at He II temperatures. The docstring says so.Evidence
temperature_responsecould only use SolarSoft's CHIANTI 9 emissivity.After:
test_temperature_response_chianti11checks 94 and 335 Å at log T 6.0, 6.4 and 7.0 against sdo's independent CHIANTI 11 table (rtol 2e-4; 3e-3 at log T 6.4 where sdo's table lacks the excited-level free-bound continuum; 1.5e-3 for 335 Å, which sees He II through the short-wavelength wing of its filter and sdo boosts one member).test_chiantifix_requires_ssw_spectranow uses the real CHIANTI 11 spectra. 10 passed locally with the file served from a checkout. The gallery example gains the 94 Å comparison: SolarSoft, SolarSoft with chiantifix, CHIANTI 11.Merge Danger
Door: two-way
Blast Radius: one keyword
The default is unchanged; the tests need the file on backup-files'
aiabranch (LM-SAL/backup-files#19).Summary by Sourcery
Add selectable CHIANTI 11 emissivity support while preserving SolarSoft as the default source.
New Features:
get_source_spectra.Bug Fixes:
Enhancements:
Documentation:
Tests: