[Quest] Implement X Marks the Spot #6367

slashtangent · 2024-10-18T03:29:01Z

I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
I have read and understood the Contributing Guide and the Code of Conduct.
I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Add the quest "X Marks the Spot" and removes unused code from _0r9.lua

Steps to test these changes

-- Tavnazian Safehold !zone 26
Talk to Despachiaire
-- Despachiaire !pos 111.2090 -40.0148 -85.4810
Talk to Parelbriaux
-- Parelbriaux !pos 113.701 -41 42.3653
Talk to Odeya
-- Odeya !pos 83.3227 -34.25 -70.0384
Trade Tavanzian Liver to Odeya !additem 5154
-- Phomiuna Aqueducts !zone 27
Check Gate:
-- Hidden Hallway 2nd Gate !pos 138.1027 -24 60.3209
-- Tavnazian Safehold !zone 26
Talk to Odeya to end quest.
-- Odeya !pos 83.3227 -34.25 -70.0384

Sources

Retail Capture:
Video: https://drive.google.com/open?id=10Jvy5TKRKbDSbq0_ku5hObid4AsBlvDD
Packets: https://drive.google.com/open?id=1-LEXYfCeie3kzkBpwH68jyg7pItTeE1c

Additional Capture:
Part 1: https://youtu.be/bH8bb61KUdo
Part 2: https://youtu.be/FOxpWM70ea4
https://1drv.ms/u/s!AlLEVQXhZeaHgV628MzKgxRQydEL?e=Bw04wF

* Added X Marks the Spot * Added item Tavnazian Liver * Removed unused code from _0r9

zach2good

Seems pretty reasonable to me 👍

zach2good · 2024-10-18T13:01:12Z

scripts/quests/otherAreas/X_Marks_The_Spot.lua

+                        player:confirmTrade()
+                        quest:setVar(player, 'Prog', 3)


These lines are double-indented compared to the other blocks nearby

zach2good · 2024-10-18T13:01:56Z

scripts/quests/otherAreas/X_Marks_The_Spot.lua

+                    if quest:getVar(player, 'Prog') == 3 then
+                        return quest:progressEvent(37)
+                    else
+                        return


You can get rid of the else-return here if it's going to do nothing. Presumably the ??? or whatever this is has a DefaultAction set up in the file for that zone?

Now that you've changed this and it falls out the bottom, should this 0r9 thing have a default action? What's in the cap?

local ID = zones[xi.zone.PHOMIUNA_AQUEDUCTS] return { ['_0r5'] = { messageSpecial = ID.text.DOOR_FIRMLY_SHUT }, }

In the capture, the door doesn't open and gives a line about the door being firmly shut. I've been doing research to see if there is any instance in which this door opens as it is coded (outside of the cutscene). I was going to put in a capture request to have someone test it again outside of the quest.

I suspect that the door isn't meant to open outside of the quest, but I want to verify since the code for the door opening was added way back in 2020.

I've just watched the cap, all the information needed is there. It plays you this message if there isn't a quest involved:

So set that as the default action for this door. (there may have been some ID shifts since this cap was made, so figure it out with your local client)

I'm suspicious about the doors around here, because they all have this block:

elseif npc:getAnimation() == 9 then npc:openDoor() end

I don't remember the story around this area, if gates are meant to be shut at any time, if you need keys, etc. This might just be copy/paste error, or they might legitimately need to open - and that's hard to figure out from caps

I suspect a retail character with large mission completion could quickly go there and see what the door does, but then you'd have to work backwards from "it's normally open, when is it shut?" or "it's normally shut, when is it open?"

In terms of this PR then, nothing needs to happen, the underlying object opens like it always has, and you don't change that behaviour 👍

I think you're right and it might just be a copy-paste error. @siknoz did a recent capture (almost a year after the x marks the spot capture) for me to double-check the door and it still displays the door is firmly shut. I also couldn't find any instance where the player needs to go into the room beyond here.

I'm going to go ahead and add in the default action and remove the door opening animation, if it is ever found to have a need then it can be added back.

scripts/quests/otherAreas/X_Marks_The_Spot.lua

zach2good · 2024-10-18T13:03:46Z

scripts/zones/Phomiuna_Aqueducts/npcs/_0r9.lua

@@ -21,9 +19,6 @@ entity.onEventUpdate = function(player, csid, option, npc)
 end

 entity.onEventFinish = function(player, csid, option, npc)
-    if csid == 37 then
-        player:setCharVar('X_MARKS_THE_SPOT', 5)


Interesting that these X_MARKS_THE_SPOT vars are completely vestigial, and not set/used anywhere else 🤷

It was added to the code way back in 2020. My best guess is that someone was working on it but eventually scrapped it.

slashtangent · 2024-11-05T19:49:11Z

@zach2good checking in to see if there is anything else needed here.

claywar · 2024-11-05T19:54:26Z

scripts/quests/otherAreas/X_Marks_The_Spot.lua

+    {
+        check = function(player, status, vars)
+            return status == xi.questStatus.QUEST_AVAILABLE and
+            player:getCurrentMission(xi.mission.log_id.COP) > xi.mission.id.cop.ANCIENT_VOWS


Styling a bit here, please indent returns after the first line

claywar · 2024-11-05T19:55:16Z

scripts/quests/otherAreas/X_Marks_The_Spot.lua

+        [xi.zone.TAVNAZIAN_SAFEHOLD] =
+        {
+            -- Will repeat until the quest is completed.
+            ['Despachiaire'] = quest:progressEvent(144),


Is this confirmed to be blocking? Not sure what else he could be handling, and would be fine assuming all of his other interactions are progress

Rewatching the capture it does not block. However, it is one of the scenes he cycles through depending on what you have active, and this cs will get cycled in until you complete the quest.

I'll need to recode this. However, I'm unsure how to go about making sure it still cycles in other scenes available.

Use quest:event(x)

If the other quests he is involved in are properly coded using the priority method, the cycle will happen automatically.

:progressEvent() means the event takes priority over other events of lower priority. :event() has lower priority, for instance.

If 2 events have the same priority, the cycling happens automatically.

claywar · 2024-11-05T19:56:05Z

scripts/quests/otherAreas/X_Marks_The_Spot.lua

+            ['Odeya'] =
+            {
+                onTrigger = function(player, npc)
+                    if quest:getVar(player, 'Prog') == 1 then


Please pull and assign a variable once instead of querying for every condition

scripts/quests/otherAreas/X_Marks_The_Spot.lua

slashtangent · 2024-11-22T09:16:22Z

@claywar @Xaver-DaRed Checking in on this one.

* Added X Marks the Spot * Added item Tavnazian Liver * Removed unused code from _0r9 and added default action to match captures

slashtangent added 2 commits October 16, 2024 06:16

[Quest] Implement X Marks the Spot

74ba7b8

* Added X Marks the Spot * Added item Tavnazian Liver * Removed unused code from _0r9

Merge branch 'LandSandBoat:base' into X_Marks_The_Spot

d7a8e0f

zach2good reviewed Oct 18, 2024

View reviewed changes

zach2good approved these changes Oct 18, 2024

View reviewed changes

zach2good added the squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) label Oct 18, 2024

slashtangent force-pushed the X_Marks_The_Spot branch from fee0c3f to 0edcd07 Compare October 22, 2024 02:16

claywar reviewed Nov 5, 2024

View reviewed changes

Xaver-DaRed reviewed Nov 7, 2024

View reviewed changes

scripts/quests/otherAreas/X_Marks_The_Spot.lua Show resolved Hide resolved

Xaver-DaRed reviewed Nov 7, 2024

View reviewed changes

scripts/quests/otherAreas/X_Marks_The_Spot.lua Show resolved Hide resolved

zach2good added squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) and removed squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) labels Nov 7, 2024

slashtangent force-pushed the X_Marks_The_Spot branch from 0edcd07 to dce55bb Compare November 7, 2024 19:25

[Quest] Implement X Marks the Spot

d06d386

* Added X Marks the Spot * Added item Tavnazian Liver * Removed unused code from _0r9 and added default action to match captures

slashtangent force-pushed the X_Marks_The_Spot branch from dce55bb to d06d386 Compare December 28, 2024 04:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Quest] Implement X Marks the Spot #6367

[Quest] Implement X Marks the Spot #6367

slashtangent commented Oct 18, 2024

zach2good left a comment

zach2good Oct 18, 2024

zach2good Oct 18, 2024

zach2good Oct 18, 2024

slashtangent Oct 18, 2024 •

edited

Loading

zach2good Oct 18, 2024

zach2good Oct 18, 2024

zach2good Oct 18, 2024

zach2good Oct 18, 2024

slashtangent Oct 22, 2024

zach2good Oct 18, 2024

slashtangent Oct 18, 2024

slashtangent commented Nov 5, 2024

claywar Nov 5, 2024

claywar Nov 5, 2024

slashtangent Nov 7, 2024

Xaver-DaRed Nov 7, 2024

claywar Nov 5, 2024

slashtangent commented Nov 22, 2024

[Quest] Implement X Marks the Spot #6367

Are you sure you want to change the base?

[Quest] Implement X Marks the Spot #6367

Conversation

slashtangent commented Oct 18, 2024

What does this pull request do?

Steps to test these changes

Sources

zach2good left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slashtangent Oct 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slashtangent commented Nov 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slashtangent commented Nov 22, 2024

slashtangent Oct 18, 2024 •

edited

Loading