Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Update Makefile with MODE variable that lets user combine multiple targets + more features #372

Merged
merged 12 commits into from
Aug 27, 2024

Conversation

itislu
Copy link
Collaborator

@itislu itislu commented Aug 9, 2024


  • Add MODE variable that lets user combine multiple targets.

  • Add nocolor mode.
    make nocolor rebuilds the project without colors in the prompt and printouts.
    This mode avoids the issues when moving the cursor in the input line.

  • Add term and clear targets.

    • term starts minishell in a new terminal window.
    • clear clears the terminal after compilation.
  • Rename make fast to make opt.

  • Add printouts for clean targets.

  • Add MODE printout for all targets.

  • Improve Makefile layout with more separators.

  • Change terminal window title to Crash.

  • Improve Makefile help messages.


Example of multiple targets combined using new MODE env variable

image

MODE help message

image

New make help

image

New clean messages

image

@itislu itislu added the devops Development related label Aug 9, 2024
@LeaYeh LeaYeh force-pushed the build-makefile-updates branch from f6b9ff3 to 99d1db0 Compare August 13, 2024 12:56
@itislu itislu force-pushed the build-makefile-updates branch 5 times, most recently from 80a2827 to 7232a1b Compare August 24, 2024 01:16
@itislu itislu changed the title [BUILD] Update Makefile with improvements from my philosophers project [BUILD] Update Makefile with MODE variable that lets user combine multiple targets + more features Aug 25, 2024
@itislu itislu marked this pull request as ready for review August 25, 2024 11:42
@itislu itislu force-pushed the build-makefile-updates branch from 087cd7f to db91bba Compare August 25, 2024 12:14
itislu added 12 commits August 27, 2024 21:13
The export is not just important for the library compilation, but for all rules that call make recursively.
This makes the self-documentation easier to read.
With the `MODE` variable multiple compile modes can be combined.

Also:
- Prepare Makefile for `nocolor` mode.
- Add `term` and `clear` targets.
- Add printouts for clean targets.
- Add MODE printout for all targets.
- Improve Makefile layout.
- Change terminal window title to `Crash`.
With `make nocolor`, rebuild the project without colors in the prompt and printouts.
This mode avoids the issues when moving the cursor in the input line.
@itislu itislu force-pushed the build-makefile-updates branch from db91bba to 0e039cb Compare August 27, 2024 19:14
@itislu itislu merged commit 6945f20 into main Aug 27, 2024
41 checks passed
@itislu itislu deleted the build-makefile-updates branch August 27, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Development related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants