[BUILD] Add a SRC_EXTENSION variable to Makefile
#380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why the makefile need to be extended? |
This makes the Makefile easier to reuse for other projects, also with other languages, like C++. Today I debugged my C++ Makefile, which is based on this one, for a long time bc I missed that it expected source files to end with `.c` and not `.cpp`.
itislu
force-pushed
the
build-src-extension
branch
from
586f2d3 to
63f9dc5
Compare
|
I would like to keep this Makefile as a reference Makefile bc a lot of people might see it. |
LeaYeh
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Makefile easier to reuse for other projects, also with other languages, like C++.
Today I debugged my C++ Makefile, which is based on this one, for a long time bc I missed that it expected source files to end with
.cand not.cpp.