This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Regressions due to branching between JavaScript and TypeScript files #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofreyssinet-ledger
changed the title
|
ofreyssinet-ledger
changed the title
thomasrogerlux
approved these changes
Apr 5, 2022
ofreyssinet-ledger
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
<OpenDebugEnv />). (cf. LIVE-559 Ledger Nano S Plus support in Device Actions + other assets #2172)<Scanning />pair device screen: (cf. LL-6987 Use localname for ble devices when available #2017.)GenericErrorView-> this view should check the bluetooth permission in case the error is an instance ofBluetoothRequired. (cf. LL-5867 - Prompt user to activate bluetooth #2131)OperationRow, the NFT name was not being rendered for NFT operations.More context for this PR:
I made a script in
scripts/v3check.jsfor the purpose of comparing git history between JS files and their TS/TSX counterpart.Basically it checks the creation date of a tsx file (e.g.
filename.ts|tsx) and lists all the commits that happened since that date on the corresponding file (filename.js). It then generates a markdown string with a TODO list, that you can see in the following comment on this PR.This allows us to detect changes that might have been done on one side in
developand might not have been included in the rebranding files (the typescript ones).The script is quite rudimentary so it might not catch everything but it caught two of the regressions that we already identified before (regression on the "region setting" feature #2332 and regression on some fixes on the discreet mode #2365 ).
On top of that as you can see in the following list it helped me to catch some other regressions (Upon checking each commit in the list one by one, I then added for the 🚨 emoji whenever I found a regression) that happened because of the branching between js and ts files.
I'm pushing the script to the repo even though it will probably not be used anymore on LLM, but it might be useful for the pre-release of the LLD rebranding. Eventually we can delete it.
Type
Regression fixes
Context
v3 pre-release
Parts of the app affected / Test plan