Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add registry url to captain deployment #268

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

ambersun1234
Copy link
Contributor

@ambersun1234 ambersun1234 commented Nov 29, 2024

Summary by Sourcery

New Features:

  • Add IMAGE_REGISTRY_URL environment variable to captain deployment configuration.

@ambersun1234 ambersun1234 requested a review from knowlet November 29, 2024 06:24
Copy link

sourcery-ai bot commented Nov 29, 2024

Reviewer's Guide by Sourcery

This PR adds a new environment variable IMAGE_REGISTRY_URL to the Captain deployment configuration, which is populated from the global registry URL value in the Helm chart.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added registry URL configuration to Captain deployment
  • Added IMAGE_REGISTRY_URL environment variable
  • Set environment variable value from global.registry.url Helm value
charts/agh3/templates/captain/captain-deployment.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ambersun1234 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@knowlet knowlet requested a review from Aries0d0f December 3, 2024 02:04
@ambersun1234 ambersun1234 self-assigned this Dec 9, 2024
@knowlet knowlet merged commit c9eea72 into main Dec 11, 2024
1 check passed
@knowlet knowlet deleted the feat/registry-url branch December 11, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants