Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default action result queue #273

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add default action result queue #273

wants to merge 1 commit into from

Conversation

ambersun1234
Copy link
Contributor

@ambersun1234 ambersun1234 commented Dec 13, 2024

This PR creates rabbitmq default action result queue on boot

Summary by Sourcery

Introduce a default RabbitMQ action result queue created on boot and configure its parameters in the values.yaml file.

New Features:

  • Introduce a default RabbitMQ action result queue that is created on boot.

Enhancements:

  • Add configuration for RabbitMQ queue name and load definition in the values.yaml file.

@ambersun1234 ambersun1234 self-assigned this Dec 13, 2024
Copy link

sourcery-ai bot commented Dec 13, 2024

Reviewer's Guide by Sourcery

This PR implements RabbitMQ queue configuration by adding a default action result queue that is created during system boot. The implementation includes defining the queue in RabbitMQ configuration and exposing the queue name to relevant services through environment variables.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added RabbitMQ queue definition configuration
  • Added JSON configuration for RabbitMQ queue definition
  • Configured queue with durability enabled and auto-delete disabled
  • Set up user permissions for queue management
  • Added administrator tag to RabbitMQ user
charts/agh3/templates/base/rabbitmq-secret.yml
Configured services to use the new RabbitMQ queue
  • Added RABBITMQ_QUEUE environment variable
  • Set queue name from values configuration
  • Removed liveness probe configuration from controller deployment
charts/agh3/templates/controller/controller-deployment.yml
charts/agh3/templates/captain/captain-deployment.yml
Added queue configuration parameters to values.yaml
  • Added queueName parameter with default value 'action_result'
  • Enabled load definition configuration
  • Specified existing secret for RabbitMQ configuration
charts/agh3/values.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant